Move unused eslint webpack import into @remove-on-eject block #7856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrseanbaines
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
|
Nice catch! Thanks for taking your time to submit the PR. Verified by bootstrapping new app and ejecting. |
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that when creating a new app with
create-react-app, there is an unnecessary/unusedeslintimport in the generated webpack config which can be seen if you eject the project. I have now moved this import into the@remove-on-ejectblock.Verified as working by locally running
yarn create-react-app, ejecting and viewing the new project's webpack config, where the extra import is now gone.