Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GitHub Action that runs the build script #7861

Merged
merged 1 commit into from
Oct 22, 2019

Conversation

iansu
Copy link
Contributor

@iansu iansu commented Oct 22, 2019

This is a just a quick experiment with GitHub Actions.

I realize that this particular action is not useful at all. See #7852.

@iansu iansu added this to the 3.3 milestone Oct 22, 2019
@iansu
Copy link
Contributor Author

iansu commented Oct 22, 2019

This check succeeded on my fork so I'm going to merge it.

@iansu iansu merged commit 9788522 into facebook:master Oct 22, 2019
@iansu iansu deleted the github-action-build branch October 22, 2019 02:08
@ghost ghost mentioned this pull request Oct 22, 2019
@iansu iansu added this to In progress in v3.3 via automation Oct 23, 2019
@iansu iansu moved this from In progress to Done in v3.3 Oct 23, 2019
@lock lock bot locked and limited conversation to collaborators Oct 27, 2019
@gaearon
Copy link
Contributor

gaearon commented Nov 8, 2019

FYI, there's going to be a snag with Actions after November 13 due to a planned change. They won't work for this repo until some time later (hopefully not too long after).

@iansu
Copy link
Contributor Author

iansu commented Nov 8, 2019

I'm curious to know more about that but good to know anyway. We are planning to use GitHub Actions more in the future but we'll hold off for now.

@gaearon
Copy link
Contributor

gaearon commented Nov 8, 2019

The tldr is it's just a contract thing we need to renew and it'll take a bit

@iansu
Copy link
Contributor Author

iansu commented Nov 8, 2019

Interesting. Thanks for sharing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
v3.3
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants