Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript peer dependency to react-scripts #8038

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Add TypeScript peer dependency to react-scripts #8038

merged 1 commit into from
Nov 28, 2019

Conversation

iansu
Copy link
Contributor

@iansu iansu commented Nov 27, 2019 •
edited

This is currently missing and will break Yarn PnP. We're requiring ^3.2.1 as this is the minimum version requirement of @typescript/eslint.

cc @ianschmitz @mrmckeb

Closes #8022

@iansu iansu added this to In progress in v3.3 via automation Nov 27, 2019
@iansu iansu added this to the 3.3 milestone Nov 27, 2019
@iansu iansu merged commit f6ba862 into facebook:master Nov 28, 2019
v3.3 automation moved this from In progress to Done Nov 28, 2019
@lock lock bot locked and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ianschmitz ianschmitz ianschmitz approved these changes

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

Assignees
No one assigned
Labels
CLA Signed tag: internal
Projects
No open projects
v3.3
  
Done
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

Missing peer dependency in react-scripts
3 participants
@iansu @ianschmitz @facebook-github-bot