Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing peer dependencies warnings #8479

Closed
wants to merge 2 commits into from
Closed

Fix missing peer dependencies warnings #8479

wants to merge 2 commits into from

Conversation

RDIL
Copy link
Contributor

@RDIL RDIL commented Feb 13, 2020

Fixes yarn complaining, and uses the new rules.
So far this has only seemed to be a problem while ejected though.

@@ -1,7 +1,7 @@
{
"name": "eslint-config-react-app",
"version": "5.2.0",
"description": "ESLint configuration used by Create React App",
"description": "ESLint configuration used by Create React App.",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the unneeded period change?

@ianschmitz
Copy link
Contributor

Hi @RDIL. Thanks for the PR, but it is a dupe of #7790, which will be merged shortly.

@ianschmitz ianschmitz closed this Feb 19, 2020
@lock lock bot locked and limited conversation to collaborators Feb 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants