Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace period in CSS Module classnames #8492

Merged
merged 1 commit into from
May 5, 2020
Merged

Replace period in CSS Module classnames #8492

merged 1 commit into from
May 5, 2020

Conversation

evankennedy
Copy link
Contributor

Fixes #8491

  • Replaces periods . with underscores _ in CSS modules class names generated from filenames.
  • Added test cases using a stripped down mock context.

Screenshot of the issue (more info in issue #8491)
Screenshot from 2020-02-14 21-21-26
Screenshot from 2020-02-14 21-20-38

@facebook-github-bot
Copy link

Hi @evankennedy!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@evankennedy evankennedy mentioned this pull request Feb 15, 2020
Closed
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz ianschmitz added this to the 3.4.1 milestone Feb 19, 2020
ianschmitz
ianschmitz approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@ianschmitz ianschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks for the tests as well!

@iansu iansu modified the milestones: 3.4.1, 3.4.2 Mar 20, 2020
@ianschmitz ianschmitz modified the milestones: 3.5, 4.0 May 3, 2020
@ianschmitz ianschmitz closed this May 5, 2020
@ianschmitz ianschmitz reopened this May 5, 2020
@iansu iansu merged commit 6b28c60 into facebook:master May 5, 2020
@iansu
Copy link
Contributor

iansu commented May 5, 2020

Thanks!

@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iansu iansu iansu approved these changes

@ianschmitz ianschmitz ianschmitz approved these changes

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

Assignees
No one assigned
Labels
CLA Signed tag: bug fix
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

CSS Modules period in filename
4 participants
@evankennedy @facebook-github-bot @iansu @ianschmitz