Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optional chaining and nullish coalescing support #8526

Merged
merged 1 commit into from Feb 20, 2020

Conversation

ianschmitz
Copy link
Contributor

Fixes #8445

The optional chaining and nullish coalescing plugins are now supported by @babel/preset-env, however webpack is currently lacking support for this syntax due to acornjs/acorn#890 and acornjs/acorn#891 it appears.

This issue would happen when using an aggressive browserslist configuration such as last 1 chrome version, as chrome 80 that was recently released includes native support, and therefore this syntax was no longer transformed which would cause webpack to choke.

@ianschmitz ianschmitz added this to the 3.4.1 milestone Feb 20, 2020
@ianschmitz ianschmitz merged commit 2030ee1 into facebook:master Feb 20, 2020
@ianschmitz ianschmitz deleted the fix-babel-plugins branch February 20, 2020 21:33
@lock lock bot locked and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrading to react-script 3.3.1 breaks optional chaining
2 participants