Add React.StrictMode to default templates #8558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connkat
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
ianschmitz
suggested changes
Feb 27, 2020
|
@connkat let us know if you need any help with that change. |
|
@connkat are you able to update the PR with the suggestions? If not no worries we can get 'er fixed up! |
|
@ianschmitz I can totally get this done by the weekend! Got distracted with some other things IRL but should have the PR up by Sat. |
connkat
force-pushed
the
strictmode-on-template
branch
from
ecccbc2
to
af82b63
Compare
|
Thank you @connkat! I made a few small changes — looks like you forgot to revert the changes in |
ianschmitz
changed the title
mrmckeb
approved these changes
Mar 9, 2020
There was a problem hiding this comment.
Great work, thanks @connkat - @ianschmitz I think this is good to go.
|
I'm just working on fixing CI in master. |
ianschmitz
approved these changes
Mar 9, 2020
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in
<React.StrictMode>tags to the default templates.Closes #8557