Support source maps for scss in dev environments #8638
Conversation
MKorostoff
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
|
Hi @MKorostoff! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
@facebook-github-bot not sure if anyone will receive this message, but I've completed the form you requested. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Any updates on this? |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
|
Bump |
This should resolve #5707. A basic history of that issue as I understand it: currently, create-react-app doesn't have sourcemaps for scss on development environments. This feature was briefly added two years ago in #5713, then reverted due to a bug in an upstream dependency. The upstream bug is now fixed, so we can (I believe) re-enable this feature.