Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template tests #8705

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Mar 24, 2020

Closes #8699.

As requested by @kentcdodds in #8699, I've update the template tests.

I didn't update the dependencies, since that would require Node 10+.

Copy link
Contributor

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely mergable now 👍

@ianschmitz ianschmitz added this to the 3.4.2 milestone Mar 24, 2020
@ianschmitz ianschmitz merged commit 79dbc33 into facebook:master Mar 24, 2020
@MichaelDeBoey MichaelDeBoey deleted the update-template-tests branch March 24, 2020 16:12
andyecrow pushed a commit to travelperk/create-react-app that referenced this pull request Mar 31, 2020
@lock lock bot locked and limited conversation to collaborators Apr 2, 2020
@ianschmitz ianschmitz modified the milestones: 3.5, 4.0 May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update testing-library packages for cra-template
4 participants