Support devDependencies in templates #8838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmckeb
force-pushed
the
feature/devdeps-template
branch
from
78248ed
to
ff255a5
Compare
mrmckeb
requested review from
amyrlam,
ianschmitz,
iansu and
petetnt
as code owners
mrmckeb
force-pushed
the
feature/devdeps-template
branch
from
ff255a5
to
68d0187
Compare
ianschmitz
approved these changes
May 4, 2020
| @@ -125,6 +125,27 @@ module.exports = function( | |||
|
|
|||
| const templatePackage = templateJson.package || {}; | |||
|
|
|||
| // TODO: Deprecate support for root-level `dependencies` and `scripts` in v4. | |||
There was a problem hiding this comment.
Should this say v5 then?
There was a problem hiding this comment.
I'll merge this, and fix in the next PR (which is about deprecations) - thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for templates to defined
devDependenciesalongsidedependencies.It also adds a deprecation warning for templates using the previous syntax.