Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deployment docs for Azure Static Web Apps #9042

Merged
merged 3 commits into from
Jun 14, 2020
Merged

Update deployment docs for Azure Static Web Apps #9042

merged 3 commits into from
Jun 14, 2020

Conversation

burkeholland
Copy link
Contributor

Just an update to the Azure docs for deployment for the new Azure Static Web Apps.

@facebook-github-bot
Copy link

Hi @burkeholland!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

petetnt
petetnt approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@petetnt petetnt left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure Static Web Apps are really neat, congrats on the launch!

LGTM with a nit Github -> GitHub

@burkeholland
Github -> GitHub
7184e70 
Great catch!
burkeholland
burkeholland commented May 22, 2020
View reviewed changes
Copy link
Contributor Author

@burkeholland burkeholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@burkeholland @NMinhNguyen
Apply suggestions from code review
1eac1fb 
Thank you!

Co-authored-by: Minh Nguyen <minhnguyenxx@gmail.com>
@burkeholland
Copy link
Contributor Author

Just checking back on this. Looks like the checks didn't pass, but that doesn't look like it's specific to my PR. Let me know if there is anything else I need to change here.

@ianschmitz ianschmitz added this to the 4.0 milestone Jun 14, 2020
@ianschmitz
Copy link
Contributor

All good @burkeholland. Thanks for the update and congrats on the launch as well 😄

@ianschmitz ianschmitz changed the title Update for Azure Static Web Apps Update deployment docs for Azure Static Web Apps Jun 14, 2020
@ianschmitz ianschmitz merged commit b389928 into facebook:master Jun 14, 2020
@lock lock bot locked and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NMinhNguyen NMinhNguyen NMinhNguyen left review comments

@petetnt petetnt petetnt approved these changes

@amyrlam amyrlam Awaiting requested review from amyrlam

@iansu iansu Awaiting requested review from iansu

Assignees
No one assigned
Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@burkeholland @facebook-github-bot @ianschmitz @NMinhNguyen @petetnt