feat: allow specifying custom target for FooterLogo (#7557)

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
facebook · Jun 3, 2022 · 5444a23 · 5444a23
1 parent 9d0bf2e
commit 5444a23
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/packages/docusaurus-theme-classic/src/__tests__/validateThemeConfig.test.ts b/packages/docusaurus-theme-classic/src/__tests__/validateThemeConfig.test.ts
@@ -102,6 +102,7 @@ describe('themeConfig', () => {
           alt: 'Facebook Open Source Logo',
           src: 'img/oss_logo.png',
           href: 'https://opensource.facebook.com',
+          target: '_self',
         },
         copyright: `Copyright © ${new Date().getFullYear()} Facebook, Inc. Built with Docusaurus.`,
       },

diff --git a/packages/docusaurus-theme-classic/src/theme/Footer/Logo/index.tsx b/packages/docusaurus-theme-classic/src/theme/Footer/Logo/index.tsx
@@ -32,7 +32,10 @@ function LogoImage({logo}: Props) {
 
 export default function FooterLogo({logo}: Props): JSX.Element {
   return logo.href ? (
-    <Link href={logo.href} className={styles.footerLogoLink}>
+    <Link
+      href={logo.href}
+      className={styles.footerLogoLink}
+      target={logo.target}>
       <LogoImage logo={logo} />
     </Link>
   ) : (

diff --git a/packages/docusaurus-theme-classic/src/validateThemeConfig.ts b/packages/docusaurus-theme-classic/src/validateThemeConfig.ts
@@ -364,6 +364,7 @@ export const ThemeConfigSchema = Joi.object<ThemeConfig>({
       width: Joi.alternatives().try(Joi.string(), Joi.number()),
       height: Joi.alternatives().try(Joi.string(), Joi.number()),
       href: Joi.string(),
+      target: Joi.string(),
     }),
     copyright: Joi.string(),
     links: Joi.alternatives(

diff --git a/packages/docusaurus-theme-common/src/utils/useThemeConfig.ts b/packages/docusaurus-theme-common/src/utils/useThemeConfig.ts
@@ -75,6 +75,7 @@ export type FooterLogo = {
   srcDark?: string;
   width?: string | number;
   height?: string | number;
+  target?: string;
   href?: string;
 };