-
-
Notifications
You must be signed in to change notification settings - Fork 9k
docs(v2): wrap all plugin imports in require.resolve() #2941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As per breaking change in 2.0.0-alpha0.56
Deploy preview for docusaurus-2 ready! Built with commit 9f79ac6 |
Thanks @TomBrien Do you mind updating as well the /docs folder? otherwise on next release your docs changes will be reverted. The |
My bad just hit the edit on GitHub button. Sure will move that over now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this only serves as a workaround due to a bug in the current version, and will not be necessary after we release the next alpha version is that right?. cc @SamChou19815
Yes, but I think it makes sense to make the change only in alpha-56 versioned docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, since this bug is only present in alpha.56. Could you make the necessary changes?
Ironically the first commit is what we want -e187af0
Will revert the second commit :) |
This reverts commit 5afa06e.
Thank you very much @TomBrien! |
Motivation
(Write your motivation here.)
As per the breaking change in 2.0.0-alpha56 plugin call need to be wrapped in
require.resolve(...)
. Add this to the examples.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)