Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): update DocSearch to alpha.31 #3819

Merged
merged 2 commits into from Nov 25, 2020

Conversation

francoischalifour
Copy link
Contributor

@francoischalifour francoischalifour commented Nov 25, 2020

Motivation

This updates the DocSearch version that includes a few fixes and new features:

This version displays are React development warning when using React 16 about the enterKeyHint property that's officially supported from React 17: facebook/react#18634.

Warning: React does not recognize the enterKeyHint prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase enterkeyhint instead. If you accidentally passed it from a parent component, remove it from the DOM element.

You won't see this message from React 17.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

N/A.

Related PRs

N/A.

@netlify
Copy link

netlify bot commented Nov 25, 2020

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit e30277c

https://deploy-preview-3819--docusaurus-2.netlify.app

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Nov 25, 2020
@slorber
Copy link
Collaborator

slorber commented Nov 25, 2020

thanks

almost LGTM but it looks like the shortcut key is not visible anymore for me (macos/chrome 87)

image

@francoischalifour francoischalifour changed the title feat(search): update DocSearch to alpha.30 feat(search): update DocSearch to alpha.31 Nov 25, 2020
@francoischalifour
Copy link
Contributor Author

@slorber Thanks, fixed in e30277c.

@lex111 lex111 merged commit aa2daf1 into facebook:master Nov 25, 2020
@lex111
Copy link
Contributor

lex111 commented Nov 25, 2020

@francoischalifour thanks!

@slorber
Copy link
Collaborator

slorber commented Nov 26, 2020

@francoischalifour thanks

was wondering if you could make the search input keep a constant size, with or without the keys in the search input?

As we are using SSR, having things changing size just after hydration can somehow be considered as a layout shift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants