misc: add "name" field for root package.json #5842
Merged
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When I want to submit patches to docusaurus, I use a separate branch for each PR. I like to work in different git worktrees, so I can get a clean base repo for each patch to apply. What I like to do is use the format
docusaurus@branch-name
as the worktree directory name.However,
@
is not a valid character in an npm package name, soyarn install
will fail when callinglerna bootstrap
. This patch allows this use case by adding a"name": "root"
property to package.json. It's actually done by default by newer versions of lerna when we runyarn lerna init
. This behaviour has been observed here (it's my own comment).Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
docusaurus@lerna-dirname-workaround
yarn install
succeedsWithout this patch,
yarn install
fails: