-
-
Notifications
You must be signed in to change notification settings - Fork 9k
docs(admin): update repo testing instructions to reflect v2 #5845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✔️ [V2] 🔨 Explore the source changes: b72f3cf 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61a0d119a45cf80007db2175 😎 Browse the preview: https://deploy-preview-5845--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5845--docusaurus-2.netlify.app/ |
Actually, for local testing we have already dedicated command |
Thanks, I've updated the title to better describe the purpose. |
Hey, I don't think what you suggest is the easiest way. You should rather use the |
I tested with A lot of this doc is still about v1 development anyways—it hasn't been updated for a long time. I also sent #5989 to refresh the docs. I personally think this one is good to merge. |
Yes this doc is a bit outdated.
Yes there are generally issues due to duplicate React versions found etc, you have to symlink it too and symlink all packages, not just one or 2. Last time I tried it was definitively possible. |
Motivation
I had to discover this method of installing docusaurus packages from the local repo for testing by myself -- hopefully this will help others (and maybe future me) when trying to test their local changes.
I also made some trivial changes to CONTRIBUTING.md
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
I tested the commands I added to the documentation, and they work fine:
yarn build
works