Skip to content

docs: '5 minutes tutorial' -> '5-minute tutorial' #5876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

molly
Copy link
Contributor

@molly molly commented Nov 4, 2021

Motivation

There is a typo or grammatical error in a few portions of the documentation, where people are invited to "read the 5 minutes tutorial" rather than the "5 minute tutorial".

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Just a copy change, no test changes should be required.

@molly molly requested review from lex111 and slorber as code owners November 4, 2021 20:03
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 4, 2021
@netlify
Copy link

netlify bot commented Nov 4, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 443ea60

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/618489f05d23a50007da3e58

😎 Browse the preview: https://deploy-preview-5876--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Nov 4, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 74
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5876--docusaurus-2.netlify.app/

@Josh-Cena
Copy link
Collaborator

"5 minutes tutorial" sounds less natural than "5-minute tutorial" to me, and the latter is what we use on the README. Could you take some time to re-update the content? Thanks

@molly
Copy link
Contributor Author

molly commented Nov 5, 2021

Sure thing, I've added the hyphen.

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks😄

@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 5, 2021
@Josh-Cena Josh-Cena changed the title docs: Fix a few instances where '5 minute tutorial' is written as '5 minutes tutorial' docs: '5 minutes tutorial' -> '5-minute tutorial' Nov 5, 2021
@Josh-Cena Josh-Cena merged commit 95ed6e1 into facebook:main Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants