Skip to content

chore(workflow): merge jobs into one workflow & give each job a name #5907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena commented Nov 8, 2021

Motivation

Each job needs a name, because currently when you see the "details" in a merged PR you see a lot of meaningless names:

image

In addition, there are a lot of workflows that can be merged because they have the same execution conditions. After the refactor, all jobs would have sensible names and there's a more logical division between different workflows.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

CI

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 8, 2021
@netlify
Copy link

netlify bot commented Nov 8, 2021

✔️ [V2]

🔨 Explore the source changes: 36d6ceb

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61892b02f661800008f73ce7

😎 Browse the preview: https://deploy-preview-5907--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Nov 8, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 76
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5907--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Nov 8, 2021

Size Change: -3 B (0%)

Total Size: 881 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 38.2 kB 0 B
website/build/assets/css/styles.********.css 94 kB 0 B
website/build/assets/js/main.********.js 474 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 66.1 kB 0 B
website/build/blog/index.html 36.8 kB 0 B
website/build/docs/index.html 44 kB 0 B
website/build/docs/installation/index.html 51.5 kB -3 B (0%)
website/build/index.html 29.5 kB 0 B
website/build/tests/docs/index.html 25.2 kB 0 B
website/build/tests/docs/standalone/index.html 21.7 kB 0 B

compressed-size-action

@Josh-Cena Josh-Cena merged commit 8fba542 into main Nov 8, 2021
@Josh-Cena Josh-Cena deleted the jc/simplify-workflow branch November 8, 2021 14:04
@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants