-
-
Notifications
You must be signed in to change notification settings - Fork 9k
docs: add Signoz site to showcase site #5921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @pal-sig! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
✔️ [V2] 🔨 Explore the source changes: 98772eb 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/618c7e265a81350007586869 😎 Browse the preview: https://deploy-preview-5921--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5921--docusaurus-2.netlify.app/ |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
description: 'Open source Application Performance Monitoring (APM) & Observability tool. SigNoz helps developers monitor their applications & troubleshoot problems, an open-source alternative to DataDog, NewRelic, etc. 🔥 💻', | ||
preview: require('./showcase/signoz.png'), | ||
website: 'https://signoz.io/', | ||
source: 'https://github.com/SigNoz/signoz', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this does not seem to be the source of your Docusaurus site.
Can you update the source to your site source code, or remove the open-source tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @slorber
Sorry i didn't into that. Right now site is not yet open source. probably i missed that part
Would it possible to follow this tag => 'Large Site', 'design' , 'personal' , 'product'
Let me know if this work for you and will raise a updated Pr for same
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please do a followup to remove the opensource
tag in that case. Sorry for missing that part...
Don't know if your site is personal
, since personal
and product
are usually mutually exclusive. Considering large site
, have you compared the scale of your site to others with this tag? I don't think your site is currently eligible although it's pretty close (200 pages)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No currently we don't have 200 page. yeah i think personal would not work in this case thanks for the feedback
so raising the pr for 'product','design'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Josh-Cena raised the PR
Motivation
Main Landing page is using Docusaurus v2. It could be cool to add it in the showcase page.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Ran yarn run start:v2 and check that the page http://localhost:3000/showcase is rendered properly.
Related PRs
No