Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Signoz site to showcase site #5921

Merged
merged 2 commits into from Nov 11, 2021

Conversation

palashgdev
Copy link
Contributor

Motivation

Main Landing page is using Docusaurus v2. It could be cool to add it in the showcase page.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Ran yarn run start:v2 and check that the page http://localhost:3000/showcase is rendered properly.

Related PRs

No

@facebook-github-bot
Copy link
Contributor

Hi @pal-sig!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@palashgdev palashgdev marked this pull request as ready for review November 10, 2021 15:14
@netlify
Copy link

netlify bot commented Nov 10, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 98772eb

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/618c7e265a81350007586869

😎 Browse the preview: https://deploy-preview-5921--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Nov 10, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 69
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5921--docusaurus-2.netlify.app/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 10, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Josh-Cena Josh-Cena changed the title docs(v2) - Add Signoz site to showcase site docs: add Signoz site to showcase site Nov 11, 2021
@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 11, 2021
@Josh-Cena Josh-Cena merged commit 51fbcb2 into facebook:main Nov 11, 2021
description: 'Open source Application Performance Monitoring (APM) & Observability tool. SigNoz helps developers monitor their applications & troubleshoot problems, an open-source alternative to DataDog, NewRelic, etc. 🔥 💻',
preview: require('./showcase/signoz.png'),
website: 'https://signoz.io/',
source: 'https://github.com/SigNoz/signoz',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not seem to be the source of your Docusaurus site.
Can you update the source to your site source code, or remove the open-source tag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @slorber
Sorry i didn't into that. Right now site is not yet open source. probably i missed that part

Would it possible to follow this tag => 'Large Site', 'design' , 'personal' , 'product'

Let me know if this work for you and will raise a updated Pr for same
Thanks

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please do a followup to remove the opensource tag in that case. Sorry for missing that part...

Don't know if your site is personal, since personal and product are usually mutually exclusive. Considering large site, have you compared the scale of your site to others with this tag? I don't think your site is currently eligible although it's pretty close (200 pages)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No currently we don't have 200 page. yeah i think personal would not work in this case thanks for the feedback

so raising the pr for 'product','design'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Josh-Cena raised the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants