Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(theme-classic): move some logic of CodeBlock to theme-common #5922

Merged
merged 2 commits into from Nov 12, 2021

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

To make the diff in #5783 less confusing. Moved all highlight-related code to theme-common.

Not sure if we should be less opinionated and pass the directives as params instead of hard-coded? Is there a customization need here?

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview; rendered result still the same.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 11, 2021
@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 11, 2021
@netlify
Copy link

netlify bot commented Nov 11, 2021

✔️ [V2]

🔨 Explore the source changes: 3e7b146

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/618d1e15dcaeb400083bdddd

😎 Browse the preview: https://deploy-preview-5922--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Nov 11, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 92
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5922--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Nov 11, 2021

Size Change: +2.14 kB (0%)

Total Size: 884 kB

Filename Size Change
website/build/assets/js/main.********.js 476 kB +1.85 kB (0%)
website/build/blog/2017/12/14/introducing-docusaurus/index.html 66.1 kB +42 B (0%)
website/build/docs/installation/index.html 51.7 kB +220 B (0%)
ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 38.3 kB 0 B
website/build/assets/css/styles.********.css 94.2 kB 0 B
website/build/blog/index.html 36.8 kB 0 B
website/build/docs/index.html 44 kB +29 B (0%)
website/build/index.html 29.5 kB 0 B
website/build/tests/docs/index.html 25.2 kB 0 B
website/build/tests/docs/standalone/index.html 21.7 kB 0 B

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Nov 12, 2021

Thanks 👍

Not sure if we should be less opinionated and pass the directives as params instead of hard-coded? Is there a customization need here?

We'll figure out if anyone complains and present a usecase ;)

@slorber slorber merged commit 334470b into main Nov 12, 2021
@slorber slorber deleted the jc/refactor-codeblock branch November 12, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants