Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Shotstack showcase user #5928

Merged
merged 3 commits into from Nov 12, 2021
Merged

docs: Add Shotstack showcase user #5928

merged 3 commits into from Nov 12, 2021

Conversation

jeffski
Copy link
Contributor

@jeffski jeffski commented Nov 11, 2021

Motivation

I would like to add Shotstack to the showcase of users. You can see our docs generated with Docusaurus here: https://shotstack.io/docs/guide/

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Run and check showcase page.

Related PRs

None

@facebook-github-bot
Copy link
Contributor

Hi @jeffski!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@jeffski
Copy link
Contributor Author

jeffski commented Nov 11, 2021

Signed the CLA just now for our business; Shotstack Pty Ltd.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 11, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Josh-Cena
Copy link
Collaborator

Thanks

The screenshot shows the main site which doesn't seem Docusaurus-generated. Should we include the screenshot to the actual docs instead?

@jeffski
Copy link
Contributor Author

jeffski commented Nov 12, 2021

Thanks

The screenshot shows the main site which doesn't seem Docusaurus-generated. Should we include the screenshot to the actual docs instead?

@Josh-Cena, have updated to use the documentation home page instead.

@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 12, 2021
@Josh-Cena
Copy link
Collaborator

Thanks, please check the build failure message & add the opensource tag

website/src/data/users.tsx Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Nov 12, 2021

✔️ [V2]

🔨 Explore the source changes: 8725c45

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/618e7839a62f8d00070322b7

😎 Browse the preview: https://deploy-preview-5928--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 90
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5928--docusaurus-2.netlify.app/

@slorber
Copy link
Collaborator

slorber commented Nov 12, 2021

Thanks 👍

Wonder what are your thoughts about Remotion ;)

@slorber slorber merged commit 4ab9567 into facebook:main Nov 12, 2021
@jeffski
Copy link
Contributor Author

jeffski commented Nov 15, 2021

Thanks @slorber. I have to admit Remotion is very good. A different approach to how our system works though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants