Skip to content

refactor: move deps declarations into src #5946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2021
Merged

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

For some reason (i.e. my mistake of either not committing / not pushing in #5914) there are a few declarations in the wrong place.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Build

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 14, 2021
@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 14, 2021
@netlify
Copy link

netlify bot commented Nov 14, 2021

✔️ [V2]

🔨 Explore the source changes: 494c8ee

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61909deaa07dba000761ea4d

😎 Browse the preview: https://deploy-preview-5946--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 62
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5946--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena merged commit c5feac6 into main Nov 14, 2021
@Josh-Cena Josh-Cena deleted the jc/move-declaration branch November 14, 2021 05:35
@github-actions
Copy link

Size Change: -1 B (0%)

Total Size: 884 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 38.3 kB 0 B
website/build/assets/css/styles.********.css 94.2 kB 0 B
website/build/assets/js/main.********.js 476 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 66.1 kB 0 B
website/build/blog/index.html 36.8 kB 0 B
website/build/docs/index.html 44 kB +1 B (0%)
website/build/docs/installation/index.html 51.7 kB -2 B (0%)
website/build/index.html 29.5 kB 0 B
website/build/tests/docs/index.html 25.2 kB 0 B
website/build/tests/docs/standalone/index.html 21.7 kB 0 B

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants