Skip to content

refactor(content-docs): move isCategoriesShorthand to utils #5962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Nov 17, 2021

Motivation

Move isCategoriesShorthand from types to utils
Ensure that type imports are marked as such

Have you read the Contributing Guidelines on pull requests?

yes

Note

maybe we should consider enabling

    {
      files: ['*.ts', '*.tsx'],
      rules: {
        '@typescript-eslint/consistent-type-imports': [
          ERROR,
          {
            prefer: 'type-imports',
            disallowTypeAnnotations: false,
          },
        ],
      },
    },

Verified

This commit was signed with the committer’s verified signature. The key has expired.
armano2 Armano
…d correct import type
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 17, 2021
@netlify
Copy link

netlify bot commented Nov 17, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: f9aef76

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61954c64ba988900076ab140

😎 Browse the preview: https://deploy-preview-5962--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 80
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5962--docusaurus-2.netlify.app/

@armano2 armano2 changed the title refactor(plugin-content-docs): move isCategoriesShorthand to utils ad correct import type refactor(plugin-content-docs): move isCategoriesShorthand to utils Nov 17, 2021
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks👍

I did think about consistent-type-imports, but when we do both value and type imports (e.g. with React), it's split into two lines. I'd rather wait until ts-eslint supports type import/export modifiers

@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 18, 2021
@Josh-Cena Josh-Cena merged commit 2f7d6fe into facebook:main Nov 18, 2021
@Josh-Cena Josh-Cena changed the title refactor(plugin-content-docs): move isCategoriesShorthand to utils refactor(content-docs): move isCategoriesShorthand to utils Nov 18, 2021
@armano2 armano2 deleted the plugin-content-docs-import-type branch November 18, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants