Skip to content

refactor(website): polish on Showcase page #5969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 20, 2021
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Nov 18, 2021

Motivation

Follow-up on #5742

  • co-locate showcase comps close to page
  • fix toggle shadow issue
  • move users validation to Jest test
  • add test for image size
  • replace many screenshots

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

tests

@slorber slorber added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Nov 18, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 18, 2021
@netlify
Copy link

netlify bot commented Nov 18, 2021

✔️ [V2]

🔨 Explore the source changes: 6b670fe

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6199247d3cb7af0008dc5cc3

😎 Browse the preview: https://deploy-preview-5969--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Nov 18, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 77
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5969--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Nov 18, 2021

Size Change: +56 B (0%)

Total Size: 890 kB

Filename Size Change
website/build/assets/css/styles.********.css 100 kB +45 B (0%)
ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 38.3 kB 0 B
website/build/assets/js/main.********.js 476 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 66.1 kB 0 B
website/build/blog/index.html 36.8 kB 0 B
website/build/docs/index.html 44 kB +7 B (0%)
website/build/docs/installation/index.html 51.7 kB +4 B (0%)
website/build/index.html 29.5 kB 0 B
website/build/tests/docs/index.html 25.2 kB 0 B
website/build/tests/docs/standalone/index.html 21.7 kB 0 B

compressed-size-action

@Josh-Cena
Copy link
Collaborator

I doubt if the subdued separator is visible enough...

image

I have a feeling that if we unify the height of all images, using the primary color separator is going to show a better visual consistency

@Josh-Cena Josh-Cena added pr: documentation This PR works on the website or other text documents in the repo. and removed pr: polish This PR adds a very minor behavior improvement that users will enjoy. labels Nov 20, 2021
@slorber
Copy link
Collaborator Author

slorber commented Nov 20, 2021

For me, the goal of that separator is not to be the most visible, just to be visible enough so that it's clear there's a separation, in case of using an image with a white background on a card with a white background too.

This does not look so great to me:

image

Going to merge now but open to iterate on this design again if people think we can do better

@slorber slorber merged commit 668f3c2 into main Nov 20, 2021
@slorber slorber deleted the slorber/showcase-polish branch November 20, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants