-
-
Notifications
You must be signed in to change notification settings - Fork 9k
refactor(website): polish on Showcase page #5969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✔️ [V2] 🔨 Explore the source changes: 6b670fe 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6199247d3cb7af0008dc5cc3 😎 Browse the preview: https://deploy-preview-5969--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5969--docusaurus-2.netlify.app/ |
Size Change: +56 B (0%) Total Size: 890 kB
ℹ️ View Unchanged
|
For me, the goal of that separator is not to be the most visible, just to be visible enough so that it's clear there's a separation, in case of using an image with a white background on a card with a white background too. This does not look so great to me: Going to merge now but open to iterate on this design again if people think we can do better |
Motivation
Follow-up on #5742
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
tests