Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Remirror to showcase #5970

Merged
merged 2 commits into from Nov 19, 2021
Merged

docs: add Remirror to showcase #5970

merged 2 commits into from Nov 19, 2021

Conversation

ronnyroeller
Copy link
Contributor

Motivation

Add showcase

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

N/A

Related PRs

N/A

@facebook-github-bot
Copy link
Contributor

Hi @ronnyroeller!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Nov 19, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: c9e4e36

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61978d13f4a6310007b40893

😎 Browse the preview: https://deploy-preview-5970--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 89
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5970--docusaurus-2.netlify.app/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 19, 2021
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

It's indeed a large site. You may be interested in having multiple sidebars like the ts-eslint website so that the API / extension lists don't cause the sidebar to grow indefinitely

@Josh-Cena Josh-Cena merged commit 77c99a1 into facebook:main Nov 19, 2021
@Josh-Cena Josh-Cena changed the title docs: Add Remirror to showcase docs: add Remirror to showcase Nov 19, 2021
@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants