-
-
Notifications
You must be signed in to change notification settings - Fork 9k
feat(theme-translations): add extra Korean translation, fix typo #5976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✔️ [V2] 🔨 Explore the source changes: 436c74a 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61afaa77aca90700075b9581 😎 Browse the preview: https://deploy-preview-5976--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5976--docusaurus-2.netlify.app/ |
Hi, thanks for your time on this! #5849 has done some refactorings to the translation system, which will cause merge conflicts in your PR after that one got merged (or vice versa: we merge yours and have to fix the conflicts in that one.) We'd also like to try out the new translation workflow. So while your PR looks good to me (especially the fact that it fixes the "ko only has one plural form" warning), would you kindly stay with us for a while and resolve the conflicts after we merge #5849? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not experienced with Korean at all but hope these comments can help you complete the translations
This one can wait. Just ping me when the 5849 is merged and this can be worked on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
"Blog archive" is not easy to translate. I went for "blog history" in zh-Hans
, but "blog list" also sounds good
Thanks Theme changes have been merged, it may be simpler to create another new PR with these changes ported to the new system: https://github.com/facebook/docusaurus/tree/main/packages/docusaurus-theme-translations/locales/ko |
At least I wouldn't like seeing a PR closed on my timeline😄 @revi Whether to submit a new one or just resolve conflicts in the current one (or let me do it, if you wish), your call |
@Josh-Cena You can feel free to rebase and merge :-) (Thanks in advance!) |
Ah, okay, I'll do it then. Thanks again! |
@revi actually, I do not have write access because your fork is an org fork not a personal fork. Do you see a checkbox on the right sidebar to allow write access to maintainers? |
Signed-off-by: Yongmin Hong <revi@pobox.com>
Resolves most comments, more fix. Signed-off-by: Yongmin Hong <revi@pobox.com>
add the missing bit. Signed-off-by: Yongmin Hong <revi@pobox.com>
48ab8ac
to
436c74a
Compare
Motivation
Updated a few translation string that was left untranslated (probably added after the initial translation?). Those left are because I had no idea where it belongs to. Also fixing a typo with Version.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
This probably does not require test plans.
Related PRs
N/A