Skip to content

chore: generate dogfooding test for long pathname during CI #5977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2021

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Fix #5793. It would still be cool to verify that things do work, but generating the file during CI ensures Windows contributors don't get unnecessarily hindered by the extra configuration needed.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Windows tests

Verified

This commit was signed with the committer’s verified signature.
Josh-Cena Joshua Chen
@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 20, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 20, 2021
@netlify
Copy link

netlify bot commented Nov 20, 2021

✔️ [V2]

🔨 Explore the source changes: 513baa6

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61988cf0af138c0008927d96

😎 Browse the preview: https://deploy-preview-5977--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Nov 20, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 87
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5977--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Nov 20, 2021

Size Change: -1.35 kB (0%)

Total Size: 890 kB

Filename Size Change
website/build/assets/js/main.********.js 476 kB -1.35 kB (0%)
ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 38.3 kB 0 B
website/build/assets/css/styles.********.css 100 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 66.1 kB 0 B
website/build/blog/index.html 36.8 kB 0 B
website/build/docs/index.html 44 kB +1 B (0%)
website/build/docs/installation/index.html 51.7 kB -2 B (0%)
website/build/index.html 29.5 kB 0 B
website/build/tests/docs/index.html 25.2 kB 0 B
website/build/tests/docs/standalone/index.html 21.7 kB 0 B

compressed-size-action

Verified

This commit was signed with the committer’s verified signature.
Josh-Cena Joshua Chen

Verified

This commit was signed with the committer’s verified signature.
Josh-Cena Joshua Chen
@Josh-Cena Josh-Cena merged commit 87a486a into main Nov 20, 2021
@Josh-Cena Josh-Cena deleted the jc/remove-long-path branch November 20, 2021 06:18
@slorber
Copy link
Collaborator

slorber commented Nov 20, 2021

👍 thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloning the latest repo on Windows failed: Filename too long
3 participants