-
-
Notifications
You must be signed in to change notification settings - Fork 9k
chore: cleanup dependency declaration in package.json #5985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✔️ [V2] 🔨 Explore the source changes: bda9551 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/619c728112c3bc00071081ac 😎 Browse the preview: https://deploy-preview-5985--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5985--docusaurus-2.netlify.app/ |
4bfd893
to
8d73365
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup! LGTM
I do wonder if there's any tooling to catch these unused deps. Recently I'm also thinking about bumping our yarn to berry
There are some tools but don't know all of them. Tried to use this one in the past but it lead to too many errors, but worth trying it again: https://github.com/Thinkmill/manypkg one thing I like is the ability to ensure all deps in the monorepo are using the same semver range for example |
* deps: add/move dependencies and treat types as dev * chore: fix merge conflict * Update package.json Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
No description provided.