Skip to content

chore: cleanup dependency declaration in package.json #5985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 23, 2021

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Nov 22, 2021

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 22, 2021
@netlify
Copy link

netlify bot commented Nov 22, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: bda9551

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/619c728112c3bc00071081ac

😎 Browse the preview: https://deploy-preview-5985--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Nov 22, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 93
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5985--docusaurus-2.netlify.app/

@armano2 armano2 force-pushed the deps/cleanup-dependencies branch from 4bfd893 to 8d73365 Compare November 22, 2021 05:35
@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 22, 2021
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! LGTM

I do wonder if there's any tooling to catch these unused deps. Recently I'm also thinking about bumping our yarn to berry

@Josh-Cena Josh-Cena changed the title deps: add/move dependencies and treat types as dev chore: cleanup dependency declaration in package.json Nov 23, 2021
@Josh-Cena Josh-Cena merged commit 411b9aa into facebook:main Nov 23, 2021
@slorber
Copy link
Collaborator

slorber commented Nov 24, 2021

There are some tools but don't know all of them.

Tried to use this one in the past but it lead to too many errors, but worth trying it again: https://github.com/Thinkmill/manypkg

one thing I like is the ability to ensure all deps in the monorepo are using the same semver range for example

slorber pushed a commit that referenced this pull request Nov 24, 2021
* deps: add/move dependencies and treat types as dev

* chore: fix merge conflict

* Update package.json

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
@armano2 armano2 deleted the deps/cleanup-dependencies branch November 24, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants