Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update react-live to 2.3.0 #5996

Closed
wants to merge 1 commit into from

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Nov 23, 2021

Motivation

follow up of core-js alignment from #5995

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Manual tests in https://deploy-preview-5996--docusaurus-2.netlify.app/docs/markdown-features/code-blocks/#interactive-code-editor

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 23, 2021
@netlify
Copy link

netlify bot commented Nov 23, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 0d7f8b7

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/619d21b6754baf00071ef846

😎 Browse the preview: https://deploy-preview-5996--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 74
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5996--docusaurus-2.netlify.app/

@lex111
Copy link
Contributor

lex111 commented Nov 23, 2021

Actually, this version of react-live has compatibility issues with React v17 (see #5556 for more details), so we better shouldn't use it for now.

@armano2 armano2 closed this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants