refactor(website): various fixes and improvements on Showcase page #5997
+88
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lex111
added
the
pr: maintenance
|
✔️ [V2] 🔨 Explore the source changes: 3ac587e 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61a0aa3c18b9f7000702f4f0 😎 Browse the preview: https://deploy-preview-5997--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5997--docusaurus-2.netlify.app/ |
|
Size Change: -804 B (0%) Total Size: 891 kB
ℹ️ View Unchanged
|
Josh-Cena
added
pr: documentation
Josh-Cena
reviewed
Nov 24, 2021
| .showcaseCardTitle a:focus-visible::after { | ||
| width: 100%; | ||
| .showcaseCardTitle a:not(:focus):hover { | ||
| background-size: 100% 1px; |
| history.push({ | ||
| ...location, | ||
| search: searchParams.toString(), | ||
| state: {scroll: window.scrollY}, |
There was a problem hiding this comment.
Is it possible to preserve the focus here, e.g. refocus to the last toggled element? It's already a great improvement
There was a problem hiding this comment.
Yes, it makes sense, just made a basic implementation of it, but feel free to improve the code if you want (I won't have a chance to do it until the weekend).
website/src/pages/showcase/_components/ShowcaseFilterToggle/styles.module.css
Show resolved
Hide resolved
Josh-Cena
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
aria-describedbyshould be used on interactive/focusable elementsHave you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)