Skip to content

chore: upgrade webpack-dev-server to v4.5.0 #5998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 24, 2021
Merged

chore: upgrade webpack-dev-server to v4.5.0 #5998

merged 3 commits into from
Nov 24, 2021

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Nov 23, 2021

Motivation

See https://github.com/webpack/webpack-dev-server/releases/tag/v4.5.0

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Try to run dev server locally.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 23, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 23, 2021
@netlify
Copy link

netlify bot commented Nov 23, 2021

✔️ [V2]

🔨 Explore the source changes: f74a0ea

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/619e00e00f956900095e1d7f

😎 Browse the preview: https://deploy-preview-5998--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Nov 23, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 93
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5998--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Nov 23, 2021

Size Change: +5 B (0%)

Total Size: 892 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 38.3 kB 0 B
website/build/assets/css/styles.********.css 100 kB 0 B
website/build/assets/js/main.********.js 477 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 66.2 kB 0 B
website/build/blog/index.html 37.8 kB 0 B
website/build/docs/index.html 44 kB +4 B (0%)
website/build/docs/installation/index.html 51.7 kB +1 B (0%)
website/build/index.html 29.5 kB 0 B
website/build/tests/docs/index.html 25.2 kB 0 B
website/build/tests/docs/standalone/index.html 21.7 kB 0 B

compressed-size-action

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 we can merge this if you think it's ready

we'll figure out possible issues while working on Docusaurus until next release

@Josh-Cena Josh-Cena merged commit b31044d into main Nov 24, 2021
@Josh-Cena Josh-Cena deleted the lex111/wds450 branch November 24, 2021 09:41
slorber pushed a commit that referenced this pull request Nov 24, 2021

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
* chore: upgrade webpack-dev-server to v4.5.0

* Fixes after review

* remove type assertion

Co-authored-by: Josh-Cena <sidachen2003@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants