-
-
Notifications
You must be signed in to change notification settings - Fork 9k
chore: upgrade webpack-dev-server to v4.5.0 #5998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✔️ [V2] 🔨 Explore the source changes: f74a0ea 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/619e00e00f956900095e1d7f 😎 Browse the preview: https://deploy-preview-5998--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5998--docusaurus-2.netlify.app/ |
Size Change: +5 B (0%) Total Size: 892 kB ℹ️ View Unchanged
|
3486e05
to
96dfaff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 we can merge this if you think it's ready
we'll figure out possible issues while working on Docusaurus until next release
* chore: upgrade webpack-dev-server to v4.5.0 * Fixes after review * remove type assertion Co-authored-by: Josh-Cena <sidachen2003@gmail.com>
Motivation
See https://github.com/webpack/webpack-dev-server/releases/tag/v4.5.0
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Try to run dev server locally.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)