docs: improve explanation for url config in GH Pages #6006
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martinsos
requested review from
Josh-Cena,
lex111 and
slorber
as code owners
7 tasks
|
✔️ [V2] 🔨 Explore the source changes: 13cbebb 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/619f47b74b72460008920ff5 😎 Browse the preview: https://deploy-preview-6006--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6006--docusaurus-2.netlify.app/ |
Josh-Cena
approved these changes
Nov 25, 2021
Josh-Cena
changed the title
Josh-Cena
added
the
pr: documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by #6004 -> docs mention what to change when custom domain is used with github pages, but don't mention changing the
url, which can be confusing (it was for me).