docs: improve algolia integration instructions #6008
Conversation
The current version makes it look like you need to install `@docusaurus/theme-search-algolia` on top the classic version to work, but it already works with the classic version. Adding `@docusaurus/theme-search-algolia` on top leads to errors.
|
Hi @shafy! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
✔️ [V2] 🔨 Explore the source changes: 9062560 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/619f7a023001de000741eb97 😎 Browse the preview: https://deploy-preview-6008--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6008--docusaurus-2.netlify.app/ |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Thanks, made some changes because not all users use the classic preset (especially into the future), and indeed the installation has caused confusions (typescript-eslint/typescript-eslint#4187 (comment)), so made it more explicit
Josh-Cena
added
the
pr: documentation
|
Awesome, thanks @Josh-Cena |
Motivation
The current version makes it look like you need to install
@docusaurus/theme-search-algoliaon top the classic version to work, but it already works with the classic version. Adding@docusaurus/theme-search-algoliaon top leads to errors.