Skip to content

docs: add Tremor website to showcase page #6015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2021

Conversation

skoech
Copy link

@skoech skoech commented Nov 26, 2021

Signed-off-by: Sharon Koech sharonkoech5147@gmail.com

Motivation

A few months ago, we decided to redesign our website using a framework that unified all of our content forms (www, docs, rfcs and courseware) under a single consolidated theme and design. After a lot of deliberation, Docusaurus was our clear answer! We loved it then, and we still love it now.
We would be very happy and honoured if you would consider adding our website to your showcase page, along with the other absolutely fantastic sites.
Thanks!

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Run npm run start.

Related PRs

None.

Signed-off-by: Sharon Koech <sharonkoech5147@gmail.com>
@facebook-github-bot
Copy link
Contributor

Hi @skoech!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Signed-off-by: Sharon Koech <sharonkoech5147@gmail.com>
@netlify
Copy link

netlify bot commented Nov 26, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 7086308

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61a142c3c9c8c800071c30cb

😎 Browse the preview: https://deploy-preview-6015--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Nov 26, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 63
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6015--docusaurus-2.netlify.app/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 26, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 26, 2021
@skoech skoech changed the title Add Tremor Website to Docusaurus Showcase Page docs: add Tremor website to showcase page Nov 26, 2021
@slorber
Copy link
Collaborator

slorber commented Nov 26, 2021

Thanks!

We'd be happy to do so

Can you send a screenshot with a little more height? This is important so that card headers are not cropped:

image

@skoech
Copy link
Author

skoech commented Nov 26, 2021

Ah, I see. On it!

Signed-off-by: Sharon Koech <sharonkoech5147@gmail.com>
@Josh-Cena Josh-Cena merged commit 43f1347 into facebook:main Nov 27, 2021
@skoech
Copy link
Author

skoech commented Nov 27, 2021

How cool. Thank you so much for having us! :)

@Josh-Cena
Copy link
Collaborator

Thanks for the detailed writeup as well @skoech decent field research

@skoech
Copy link
Author

skoech commented Nov 27, 2021

Much obliged. :)

@skoech skoech deleted the tremor-showcase branch November 27, 2021 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants