Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix error boundary import disrupting CSS order #6052

Merged
merged 3 commits into from Dec 8, 2021

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Quick fix in place of #5987. This is much less risky than reordering all CSS.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

The CSS errors are still gone

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Dec 4, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 4, 2021
@netlify
Copy link

netlify bot commented Dec 4, 2021

✔️ [V2]

🔨 Explore the source changes: 889ad7f

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61b002bccc31cc0008ebfba1

😎 Browse the preview: https://deploy-preview-6052--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Dec 4, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 75
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6052--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Dec 4, 2021

Size Change: -534 B (0%)

Total Size: 655 kB

Filename Size Change
website/build/assets/css/styles.********.css 101 kB -88 B (0%)
website/build/assets/js/main.********.js 485 kB -446 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 40.1 kB
website/build/index.html 29.5 kB

compressed-size-action

@Josh-Cena Josh-Cena added the status: awaiting review This PR is ready for review, will be merged after maintainers' approval label Dec 5, 2021
@slorber
Copy link
Collaborator

slorber commented Dec 8, 2021

Thanks 👍 wanted to do this :D Also fixed the blog tags CSS issue

@slorber slorber merged commit 59f81e6 into main Dec 8, 2021
@slorber slorber deleted the jc/error-boundary-import branch December 8, 2021 10:13
@Josh-Cena Josh-Cena removed the status: awaiting review This PR is ready for review, will be merged after maintainers' approval label Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants