Skip to content

refactor(website): improve wording in comments of showcase data #6062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2021
Merged

refactor(website): improve wording in comments of showcase data #6062

merged 2 commits into from
Dec 7, 2021
+2 −1

Conversation

sohamsshah
Copy link
Contributor

Change: widely -> wisely

Removed: // Please choose widely, we'll remove unappropriate tags
Changed: // Please choose wisely, we'll remove unappropriate tags
`` 

Very small nitpick. Thanks for reviewing it in advance

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 7, 2021
@sohamsshah sohamsshah changed the title typo in comments typo in comments at website/data/users.tsx Dec 7, 2021
@netlify
Copy link

netlify bot commented Dec 7, 2021 •
edited
Loading

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: c1f72e1

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61af4e82437e470008e170b4

😎 Browse the preview: https://deploy-preview-6062--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Dec 7, 2021 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 94
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6062--docusaurus-2.netlify.app/

@Josh-Cena
Copy link
Collaborator

This is actually correct. "Choose widely" means "choose whatever you think has the slightest possibility to be appropriate". I know it's a little confusing.

@Josh-Cena Josh-Cena closed this Dec 7, 2021
@Josh-Cena Josh-Cena reopened this Dec 7, 2021
@Josh-Cena
Copy link
Collaborator

Actually, let's do improve the comment!

@Josh-Cena Josh-Cena changed the title typo in comments at website/data/users.tsx refactor(website): fix typo in comments of showcase data Dec 7, 2021
@Josh-Cena Josh-Cena changed the title refactor(website): fix typo in comments of showcase data refactor(website): improve wording in comments of showcase data Dec 7, 2021
@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Dec 7, 2021
@sohamsshah
Copy link
Contributor Author

This looks better! 😁 Atleast my issue helped a bit 🤏

@Josh-Cena
Copy link
Collaborator

Indeed. Thanks for the contribution!

@Josh-Cena Josh-Cena merged commit c64987e into facebook:main Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena

@lex111 lex111

@slorber slorber

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sohamsshah @Josh-Cena @facebook-github-bot