Skip to content

refactor(core): fix types for client code #6064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 7, 2021
Merged

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Minor improvements. Fix any types & use more idiomatic typescript.

Test Plan

Build

Verified

This commit was signed with the committer’s verified signature.
Josh-Cena Joshua Chen

Verified

This commit was signed with the committer’s verified signature.
Josh-Cena Joshua Chen
@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Dec 7, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 7, 2021
@netlify
Copy link

netlify bot commented Dec 7, 2021

✔️ [V2]

🔨 Explore the source changes: 9538f3d

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61af69e9ba38d200071664a4

😎 Browse the preview: https://deploy-preview-6064--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 70
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6064--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

Size Change: +7 B (0%)

Total Size: 656 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 40.1 kB 0 B
website/build/assets/css/styles.********.css 101 kB 0 B
website/build/assets/js/main.********.js 485 kB +7 B (0%)
website/build/index.html 29.5 kB 0 B

compressed-size-action

@Josh-Cena Josh-Cena added the status: awaiting review This PR is ready for review, will be merged after maintainers' approval label Dec 7, 2021
@slorber
Copy link
Collaborator

slorber commented Dec 7, 2021

Thanks for refactoring that tree thing 🤪

@slorber slorber merged commit b4ec7ec into main Dec 7, 2021
@slorber slorber deleted the jc/routesChunkNames-refactor branch December 7, 2021 18:58
@Josh-Cena Josh-Cena removed the status: awaiting review This PR is ready for review, will be merged after maintainers' approval label Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants