refactor: remove deprecated docs homePageId option #6065
Merged
+94
−173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lex111
added
pr: breaking change
|
✔️ [V2] 🔨 Explore the source changes: 2f19533 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61af73f6e7eaf50007afe5b6 😎 Browse the preview: https://deploy-preview-6065--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6065--docusaurus-2.netlify.app/ |
|
I've thought about it, but |
|
Size Change: 0 B Total Size: 656 kB ℹ️ View Unchanged
|
|
Just fixed it, users will need to set the root doc item manually. |
Josh-Cena
added
the
status: awaiting review
|
LGTM thanks 👍 |
Josh-Cena
removed
the
status: awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
The
homePageIdhas been marked as deprecated for a long time. Users usinghomePageIdshould consider settingslug: /in the front matter of their doc file instead.Motivation
The
homePageIdhas been declared deprecated for over a year now, it's probably time to remove it.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview/tests
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)