Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(create-docusaurus): give a clearer message when installation failed #6095

Merged
merged 3 commits into from
Dec 15, 2021
Merged

fix(create-docusaurus): give a clearer message when installation failed #6095

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3dada7
fix(create-docusaurus): give a clearer message when installation failed
Josh-Cena Dec 11, 2021
ded4c3d
Fix indentation
Josh-Cena Dec 11, 2021
2ddfe2a
refactor
Josh-Cena Dec 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
29 changes: 15 additions & 14 deletions packages/create-docusaurus/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,32 +269,33 @@ ${chalk.cyan('Creating new Docusaurus project...')}
}

const pkgManager = useYarn ? 'yarn' : 'npm';
// Display the most elegant way to cd.
const cdpath =
path.join(process.cwd(), name) === dest
? name
: path.relative(process.cwd(), name);
if (!cliOptions.skipInstall) {
console.log(`Installing dependencies with ${chalk.cyan(pkgManager)}...`);

try {
// Use force coloring the output, since the command is invoked by shelljs, which is not the interactive shell
if (
shell.exec(
`cd "${name}" && ${useYarn ? 'yarn' : 'npm install --color always'}`,
{
env: {
...process.env,
// Force coloring the output, since the command is invoked by shelljs, which is not the interactive shell
...(supportsColor.stdout ? {FORCE_COLOR: '1'} : {}),
},
},
);
} catch (err) {
console.log(chalk.red('Installation failed.'));
throw err;
).code !== 0
) {
console.error(chalk.red('Dependency installation failed.'));
console.log(`The site directory has already been created, and you can retry by typing:

${chalk.cyan('cd')} ${cdpath}
${chalk.cyan(`${pkgManager} install`)}`);
process.exit(0);
}
}
console.log();

// Display the most elegant way to cd.
const cdpath =
path.join(process.cwd(), name) === dest
? name
: path.relative(process.cwd(), name);

console.log(`
Successfully created "${chalk.cyan(cdpath)}".
Expand Down