Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove some useless code #6118

Merged
merged 1 commit into from
Dec 17, 2021
+1 −39
Merged

refactor: remove some useless code #6118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 0 additions & 12 deletions packages/docusaurus-theme-classic/src/theme-classic.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,18 +202,6 @@ declare module '@theme/hooks/useHideableNavbar' {
export default useHideableNavbar;
}

declare module '@theme/hooks/useLocationHash' {
import type {Dispatch, SetStateAction} from 'react';

export type useLocationHashReturns = readonly [
string,
Dispatch<SetStateAction<string>>,
];

const useLocationHash: (initialHash: string) => useLocationHashReturns;
export default useLocationHash;
}

declare module '@theme/hooks/useLockBodyScroll' {
const useLockBodyScroll: (lock?: boolean) => void;
export default useLockBodyScroll;
Expand Down
3 changes: 1 addition & 2 deletions packages/docusaurus-theme-classic/src/theme/NavbarItem/DropdownNavbarItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ function DropdownNavbarItemDesktop({
...props
}: DesktopOrMobileNavBarItemProps) {
const dropdownRef = useRef<HTMLDivElement>(null);
const dropdownMenuRef = useRef<HTMLUListElement>(null);
const [showDropdown, setShowDropdown] = useState(false);

useEffect(() => {
Expand Down Expand Up @@ -98,7 +97,7 @@ function DropdownNavbarItemDesktop({
}}>
{props.children ?? props.label}
</NavLink>
<ul ref={dropdownMenuRef} className="dropdown__menu">
<ul className="dropdown__menu">
{items.map((childItemProps, i) => (
<NavbarItem
isDropdownItem
Expand Down
25 changes: 0 additions & 25 deletions packages/docusaurus-theme-classic/src/theme/hooks/useLocationHash.ts
View file
Open in desktop

This file was deleted.