docs: add ToolJet to showcase #6137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
withshubh
requested review from
Josh-Cena,
lex111 and
slorber
as code owners
|
✔️ [V2] 🔨 Explore the source changes: 25ae974 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61c11a78d6737d0008e6299b 😎 Browse the preview: https://deploy-preview-6137--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6137--docusaurus-2.netlify.app/ |
Josh-Cena
added
the
pr: documentation
Josh-Cena
requested changes
Dec 20, 2021
There was a problem hiding this comment.
Thanks
- Please don't choose "favorite" yourself—that's for the maintainers to decide. I personally don't think this qualifies as favorite despite being very polished and complete.
- The URL should be pointing to
https://docs.tooljet.com/, not a non-docusaurus page - Removing the color mode toggle's icons is a bad idea. You'd rather use SVG icons or something else if you don't like the emojis.
- The admonitions don't work well in dark mode:
|
@Josh-Cena 👋 Thanks for your review.
We will work on the other two suggestions too. |
|
Thanks for choosing Docusaurus! Nice site👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The documentation of ToolJet uses Docusaurus.
Have you read the Contributing Guidelines on pull requests?
Yes