Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: normalize usage of placeholders #6142

Merged
merged 1 commit into from Dec 21, 2021
Merged

docs: normalize usage of placeholders #6142

merged 1 commit into from Dec 21, 2021

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

I chose square brackets as the choice for placeholders because:

  • It's in line with the command line and webpack configuration conventions;
  • It won't conflict with any other syntaxes (e.g. our interpolation syntax {}, JSX <>...) and looks natural enough

Have you read the Contributing Guidelines on pull requests?

Yes

@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Dec 21, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 21, 2021
@netlify
Copy link

netlify bot commented Dec 21, 2021

✔️ [V2]

🔨 Explore the source changes: 89d9781

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61c1962dcf7ec10008ac8fb2

😎 Browse the preview: https://deploy-preview-6142--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 62
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6142--docusaurus-2.netlify.app/

@slorber
Copy link
Collaborator

slorber commented Dec 21, 2021

LGTM thanks 👍

@slorber slorber merged commit dedf5ac into main Dec 21, 2021
@slorber slorber deleted the jc/doc-placeholder branch December 21, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants