Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cssnano-preset): disable z-index minification #7593

Merged
merged 3 commits into from Jun 15, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/docusaurus-cssnano-preset/src/index.ts
Expand Up @@ -13,6 +13,8 @@ const preset: typeof advancedBasePreset = function preset(opts) {
const advancedPreset = advancedBasePreset({
autoprefixer: {add: false},
discardComments: {removeAll: true},
/* cSpell:ignore zindex */
zindex: false,
...opts,
});

Expand Down
1 change: 1 addition & 0 deletions website/_dogfooding/_pages tests/index.md
Expand Up @@ -28,3 +28,4 @@ import Readme from "../README.md"
- [General Markdown tests](/tests/pages/markdownPageTests)
- [TOC tests](/tests/pages/page-toc-tests)
- [Tabs tests](/tests/pages/tabs-tests)
- [z-index tests](/tests/pages/z-index-tests)
17 changes: 17 additions & 0 deletions website/_dogfooding/_pages tests/z-index-tests.tsx
@@ -0,0 +1,17 @@
/**
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/

import React from 'react';
import Layout from '@theme/Layout';

export default function zIndexTest(): JSX.Element {
return (
<Layout>
<p id="z-index-test">This should have a z-index of 100</p>
</Layout>
);
}
4 changes: 4 additions & 0 deletions website/_dogfooding/dogfooding.css
Expand Up @@ -20,3 +20,7 @@ html.plugin-blog.plugin-id-blog-tests .navbar {
html.plugin-pages.plugin-id-pages-tests .navbar {
border-bottom: solid thin yellow;
}

#z-index-test {
z-index: 100;
}
4 changes: 3 additions & 1 deletion website/docs/cli.md
Expand Up @@ -92,7 +92,9 @@ Compiles your site for production.

:::info

For advanced minification of CSS bundle, we use the [advanced cssnano preset](https://github.com/cssnano/cssnano/tree/master/packages/cssnano-preset-advanced) (along with additional several PostCSS plugins) and [level 2 optimization of clean-css](https://github.com/jakubpawlowicz/clean-css#level-2-optimizations). If as a result of this advanced CSS minification you find broken CSS, build your website with the environment variable `USE_SIMPLE_CSS_MINIFIER=true` to minify CSS with the [default cssnano preset](https://github.com/cssnano/cssnano/tree/master/packages/cssnano-preset-default). **Please [fill out an issue](https://github.com/facebook/docusaurus/issues/new?labels=bug%2C+needs+triage&template=bug.md) if you experience CSS minification bugs.**
<!-- cSpell:ignore zindex -->

For advanced minification of CSS bundle, we use the [advanced cssnano preset](https://github.com/cssnano/cssnano/tree/master/packages/cssnano-preset-advanced) with [postcss-zindex](https://github.com/cssnano/cssnano/tree/master/packages/postcss-zindex) disabled. We also use several additional PostCSS plugins and [level 2 optimization of clean-css](https://github.com/jakubpawlowicz/clean-css#level-2-optimizations). If as a result of this advanced CSS minification you find broken CSS, build your website with the environment variable `USE_SIMPLE_CSS_MINIFIER=true` to minify CSS with the [default cssnano preset](https://github.com/cssnano/cssnano/tree/master/packages/cssnano-preset-default). **Please [fill out an issue](https://github.com/facebook/docusaurus/issues/new?labels=bug%2C+needs+triage&template=bug.md) if you experience CSS minification bugs.**
Josh-Cena marked this conversation as resolved.
Show resolved Hide resolved

:::

Expand Down