New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(create): update the facebook template with current assets #7639
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. | ||
* Copyright (c) Meta Platforms, Inc. and affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
|
@@ -54,9 +54,9 @@ const config = { | |
/** @type {import('@docusaurus/preset-classic').ThemeConfig} */ | ||
({ | ||
navbar: { | ||
title: 'My Facebook Project', | ||
title: 'My Meta Project', | ||
logo: { | ||
alt: 'My Facebook Project Logo', | ||
alt: 'My Meta Project Logo', | ||
src: 'img/logo.svg', | ||
}, | ||
items: [ | ||
|
@@ -127,30 +127,32 @@ const config = { | |
items: [ | ||
{ | ||
label: 'Privacy', | ||
href: 'https://opensource.facebook.com/legal/privacy/', | ||
href: 'https://opensource.fb.com/legal/privacy/', | ||
}, | ||
{ | ||
label: 'Terms', | ||
href: 'https://opensource.facebook.com/legal/terms/', | ||
href: 'https://opensource.fb.com/legal/terms/', | ||
}, | ||
{ | ||
label: 'Data Policy', | ||
href: 'https://opensource.facebook.com/legal/data-policy/', | ||
href: 'https://opensource.fb.com/legal/data-policy/', | ||
}, | ||
{ | ||
label: 'Cookie Policy', | ||
href: 'https://opensource.facebook.com/legal/cookie-policy/', | ||
href: 'https://opensource.fb.com/legal/cookie-policy/', | ||
}, | ||
], | ||
}, | ||
], | ||
logo: { | ||
alt: 'Facebook Open Source Logo', | ||
src: 'img/oss_logo.png', | ||
href: 'https://opensource.facebook.com', | ||
alt: 'Meta Open Source Logo', | ||
// This default includes a positive & negative version, allowing for | ||
// appropriate use depending on your site's style. | ||
src: 'img/meta_opensource_logo_negative.png', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is a svg now, will fix it |
||
href: 'https://opensource.fb.com', | ||
}, | ||
// Please do not remove the credits, help to publicize Docusaurus :) | ||
copyright: `Copyright © ${new Date().getFullYear()} Facebook, Inc. Built with Docusaurus.`, | ||
copyright: `Copyright © ${new Date().getFullYear()} Meta Platforms, Inc. Built with Docusaurus.`, | ||
}, | ||
}), | ||
}; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/create-docusaurus/templates/facebook/src/css/custom.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/create-docusaurus/templates/facebook/src/pages/index.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/create-docusaurus/templates/facebook/src/pages/styles.module.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
packages/create-docusaurus/templates/facebook/static/img/meta_opensource_logo.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to update the copyright headers for the rest of the codebase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya we should if we can. I did that with Flux recently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't you also change the Facebook Open-Source logo on that Flux site?
This PR didn't change the logo on our own site, just the template one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can, but I wanted to focus on the template since that's used to start new projects. Our position has been that it's not strictly necessary to go update existing projects (and it gets really noisy) but new projects should start with "Meta".