New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(theme-translations): improve grammar of zh translation #7696
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Hi! This part is directly taken from Medium's "2 min read" format. If you ask me, I'll say it's not grammatical in English either. However, I don't know if Medium is available in Chinese translations, so I don't know how to translate it most appropriately. Do you have links to a few Chinese blogs showing similar text labels? |
Many are like "Reading Time: X minutes"
Because I don't want colon, I change it to "Reading needs X minutes"(阅读需要 X 分钟). |
packages/docusaurus-theme-translations/locales/zh-Hans/theme-common.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be fair, I use the same translation for my own site as well: https://joshcena.com/zh-Hans/blog/
So yes, I would accept this. Could you update zh-Hant
as well?
…ommon.json Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* fix: a grammar mistake * Update packages/docusaurus-theme-translations/locales/zh-Hans/theme-common.json Co-authored-by: Joshua Chen <sidachen2003@gmail.com> Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
No description provided.