Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-translations): improve grammar of zh translation #7696

Merged
merged 2 commits into from Jul 7, 2022
Merged

fix(theme-translations): improve grammar of zh translation #7696

merged 2 commits into from Jul 7, 2022

Conversation

AkagiYui
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 28, 2022
@netlify
Copy link

netlify bot commented Jun 28, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit aa5a199
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62babefbab31ec0008ab348b
😎 Deploy Preview https://deploy-preview-7696--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jun 28, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 83 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 83 🟢 100 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena
Copy link
Collaborator

Hi! This part is directly taken from Medium's "2 min read" format. If you ask me, I'll say it's not grammatical in English either. However, I don't know if Medium is available in Chinese translations, so I don't know how to translate it most appropriately. Do you have links to a few Chinese blogs showing similar text labels?

@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Jun 28, 2022
@Josh-Cena Josh-Cena changed the title fix: a grammar mistake fix(theme-translations): improve grammar of zh translation Jun 28, 2022
@AkagiYui
Copy link
Contributor Author

Many are like "Reading Time: X minutes"

Because I don't want colon, I change it to "Reading needs X minutes"(阅读需要 X 分钟).

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair, I use the same translation for my own site as well: https://joshcena.com/zh-Hans/blog/

So yes, I would accept this. Could you update zh-Hant as well?

…ommon.json

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Josh-Cena Josh-Cena merged commit bb110e5 into facebook:main Jul 7, 2022
slorber pushed a commit that referenced this pull request Jul 14, 2022
* fix: a grammar mistake

* Update packages/docusaurus-theme-translations/locales/zh-Hans/theme-common.json

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants