Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): show blog post edit link even when no tag & not truncated #7727

Merged
merged 1 commit into from Jul 6, 2022

Conversation

anaclumos
Copy link
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

I was investigating why I didn't get the EditThisPost link. I figured that it was because by default the button renders when it's either truncated or one or more tag exists. However, when editUrl is set, the button should render even when post is not truncated nor there is no tags.

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

None

@facebook-github-bot
Copy link
Contributor

Hi @anaclumos!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@anaclumos
Copy link
Contributor Author

I completed the Facebook CLA signup.

@netlify
Copy link

netlify bot commented Jul 6, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 71ad5d5
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62c4d14024cfa600087ee2a7
😎 Deploy Preview https://deploy-preview-7727--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jul 6, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 73 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 79 🟢 100 🟢 100 🟢 100 🟢 90 Report

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 6, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Josh-Cena Josh-Cena changed the title Show edit link even when no tag & not truncated. fix: show edit link even when no tag & not truncated Jul 6, 2022
@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Jul 6, 2022
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test post, as the PR template requires?

@slorber
Copy link
Collaborator

slorber commented Jul 6, 2022

Thanks 👍 LGTM

Could you add a test post, as the PR template requires?

Looks like we already have some test posts demonstrating the problem:

@slorber slorber changed the title fix: show edit link even when no tag & not truncated fix(theme): show edit link even when no tag & not truncated Jul 6, 2022
@slorber slorber changed the title fix(theme): show edit link even when no tag & not truncated fix(theme): show blog post edit link even when no tag & not truncated Jul 6, 2022
@slorber slorber merged commit a25e18c into facebook:main Jul 6, 2022
slorber added a commit that referenced this pull request Jul 6, 2022
@anaclumos anaclumos deleted the patch-1 branch July 6, 2022 18:54
slorber pushed a commit that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants