Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update FB template headers #7842

Merged
merged 1 commit into from Jul 28, 2022
Merged

chore: update FB template headers #7842

merged 1 commit into from Jul 28, 2022

Conversation

yangshun
Copy link
Contributor

@yangshun yangshun commented Jul 28, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Our internal copyright header requirements have changed.

Test Plan

Run Eslint in the facebook template

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 28, 2022
@netlify
Copy link

netlify bot commented Jul 28, 2022

[V2]

Name Link
🔨 Latest commit 1ac8f9f
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62e2265a7f3704000847536f
😎 Deploy Preview https://deploy-preview-7842--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 87 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 76 🟢 100 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

Size Change: 0 B

Total Size: 805 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.8 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 608 kB
website/build/index.html 38.9 kB

compressed-size-action

@yangshun yangshun merged commit 9150c7a into main Jul 28, 2022
@yangshun yangshun deleted the fb-template branch July 28, 2022 06:48
@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jul 28, 2022
@slorber
Copy link
Collaborator

slorber commented Aug 8, 2022

Shouldn't we change all the other headers as well?

@Josh-Cena
Copy link
Collaborator

Josh-Cena commented Aug 8, 2022

In hindsight this looks really sus 🤔 This means the template is for non-open-source sites by default? Should we at least keep the original header somewhere for reference, for open-source ones?

@yangshun
Copy link
Contributor Author

yangshun commented Aug 8, 2022

Shouldn't we change all the other headers as well?

Yes but since this is within the code, it's not as urgent. It's more urgent to update the template as this is being flagged as a violation for new projects (we have internal lint rules which conflict).

In hindsight this looks really sus 🤔 This means the template is for non-open-source sites by default? Should we at least keep the original header somewhere for reference, for open-source ones?

Hmm I didn't really consider the contents lol, was just trying to make the internal linter happy. The new internal website I was trying to change this for actually is meant to be open sourced eventually.

@zpao do you have any advice here?

@zpao
Copy link
Member

zpao commented Aug 8, 2022

This should get reverted. The headers here are intended for public code and I updated those in #7639. If we want a template for non-public headers then we can consider that but since the intent here is primarily public projects, this was already right.

was just trying to make the internal linter happy.

We'll talk elsewhere. There are better ways to do that :)

yangshun added a commit that referenced this pull request Aug 9, 2022
Josh-Cena pushed a commit that referenced this pull request Aug 9, 2022
Revert "chore: update FB template headers (#7842)"

This reverts commit 9150c7a.
@Josh-Cena Josh-Cena added pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. and removed pr: maintenance This PR does not produce any behavior differences to end users when upgrading. labels Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants