New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update FB template headers #7842
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: 0 B Total Size: 805 kB ℹ️ View Unchanged
|
Shouldn't we change all the other headers as well? |
In hindsight this looks really sus 🤔 This means the template is for non-open-source sites by default? Should we at least keep the original header somewhere for reference, for open-source ones? |
Yes but since this is within the code, it's not as urgent. It's more urgent to update the template as this is being flagged as a violation for new projects (we have internal lint rules which conflict).
Hmm I didn't really consider the contents lol, was just trying to make the internal linter happy. The new internal website I was trying to change this for actually is meant to be open sourced eventually. @zpao do you have any advice here? |
This should get reverted. The headers here are intended for public code and I updated those in #7639. If we want a template for non-public headers then we can consider that but since the intent here is primarily public projects, this was already right.
We'll talk elsewhere. There are better ways to do that :) |
Pre-flight checklist
Motivation
Our internal copyright header requirements have changed.
Test Plan
Run Eslint in the facebook template
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs