Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove mention of beta #7905

Merged
merged 2 commits into from Aug 9, 2022
Merged

docs: remove mention of beta #7905

merged 2 commits into from Aug 9, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Pre-flight checklist

Motivation

Also removed a few outdated dependencies that are duplicated from the prod dependencies and failed to be bumped

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Aug 6, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 6, 2022
@Josh-Cena Josh-Cena added the to backport This PR is planned to be backported to a stable version of Docusaurus label Aug 6, 2022
@Josh-Cena
Copy link
Collaborator Author

Adding the https://github.com/facebook/docusaurus/labels/backport because obviously the v2 package.json need to be fixed as well

@netlify
Copy link

netlify bot commented Aug 6, 2022

[V2]

Name Link
🔨 Latest commit c11f9d4
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62f294d35b6a2c00098929b1
😎 Deploy Preview https://deploy-preview-7905--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Aug 6, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 80 🟢 98 🟢 100 🟢 100 🟠 80 Report
/docs/installation 🟠 86 🟢 100 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

github-actions bot commented Aug 6, 2022

Size Change: 0 B

Total Size: 812 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.5 kB
website/build/assets/css/styles.********.css 111 kB
website/build/assets/js/main.********.js 608 kB
website/build/index.html 40.7 kB

compressed-size-action

# Conflicts:
#	packages/docusaurus-plugin-ideal-image/package.json
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'd rather have this in 2 separate PRs next time:

  • clearer pr title, nothing hidden in the impl details
  • probably also easier to backport/cherry-pick?

@slorber slorber merged commit 308d3e1 into main Aug 9, 2022
@slorber slorber deleted the jc/rm-beta branch August 9, 2022 17:26
slorber pushed a commit that referenced this pull request Sep 1, 2022
Co-authored-by: sebastienlorber <lorber.sebastien@gmail.com>
# Conflicts:
#	packages/docusaurus-plugin-ideal-image/package.json
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs still mention beta
3 participants