-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remove mention of beta #7905
Conversation
Adding the https://github.com/facebook/docusaurus/labels/backport because obviously the v2 package.json need to be fixed as well |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: 0 B Total Size: 812 kB ℹ️ View Unchanged
|
# Conflicts: # packages/docusaurus-plugin-ideal-image/package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'd rather have this in 2 separate PRs next time:
- clearer pr title, nothing hidden in the impl details
- probably also easier to backport/cherry-pick?
Co-authored-by: sebastienlorber <lorber.sebastien@gmail.com> # Conflicts: # packages/docusaurus-plugin-ideal-image/package.json
Pre-flight checklist
Motivation
Also removed a few outdated dependencies that are duplicated from the prod dependencies and failed to be bumped
Test Plan
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs