Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add new Webpack file-loader extensions: avif, mov, mkv, mpg, avi... #7941

Merged
merged 2 commits into from Aug 11, 2022

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Aug 11, 2022

Motivation

Some users get confused, as some media extensions are not supported by default by Webpack file-loader

Example with .mov here: https://twitter.com/remitbri/status/1555216969699409920

I added some extra extensions, but it's hard to be exhaustive. Feel free to add more if you have any ideas

Test Plan

none, that doesn't seem too risky 🤪

@slorber slorber added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Aug 11, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 11, 2022
@netlify
Copy link

netlify bot commented Aug 11, 2022

[V2]

Name Link
🔨 Latest commit 5a40a59
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62f4e455046000000910f306
😎 Deploy Preview https://deploy-preview-7941--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 74 🟢 98 🟢 100 🟢 100 🟠 80 Report
/docs/installation 🟠 81 🟢 100 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

Size Change: 0 B

Total Size: 812 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.5 kB
website/build/assets/css/styles.********.css 111 kB
website/build/assets/js/main.********.js 608 kB
website/build/index.html 40.7 kB

compressed-size-action

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slorber slorber merged commit b4279df into main Aug 11, 2022
@slorber slorber deleted the slorber/add-file-loader-media-patterns branch August 11, 2022 17:42
@slorber slorber added the to backport This PR is planned to be backported to a stable version of Docusaurus label Aug 12, 2022
slorber added a commit that referenced this pull request Sep 1, 2022
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants