feat(theme-classic): use lang attribute in navbar locale dropdown items #7942
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
pr: polish
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +75 B (0%) Total Size: 812 kB
ℹ️ View Unchanged
|
Josh-Cena
reviewed
Aug 11, 2022
| * `<link ... hreflang="...">` | ||
| * BCP 47 language tag to use in: | ||
| * - `<html lang="...">` | ||
| * - `<li lang="...">` |
There was a problem hiding this comment.
<li> or <a>, or doesn't really matter? Also need to put this into the actual docs since they are in sync.
There was a problem hiding this comment.
Replaced by
`<html lang="...">` (or any other DOM tag name)
Somehow HTML, li, a are all the case case 🤪
slorber
added
the
to backport
slorber
added a commit
that referenced
this pull request
Sep 1, 2022
slorber
added a commit
that referenced
this pull request
Sep 1, 2022
slorber
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Apparently, this improves accessibility a bit, and also helps SEO crawlers
https://twitter.com/mgechev/status/1518447256034238464
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/lang
https://www.w3schools.com/tags/att_global_lang.asp
Note: wonder if we shouldn't also use it for localized sites where some docs are not translated yet 🤷♂️ I guess the lang of a doc in such case is not the lang of the i18n site (as the doc is actually not translated) but the default locale instead